Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove explicit window.debug export #404

Merged
merged 1 commit into from
Dec 29, 2016
Merged

remove explicit window.debug export #404

merged 1 commit into from
Dec 29, 2016

Conversation

TooTallNate
Copy link
Contributor

Exporting to the "outer" scope of the module is more the responsibility
of the module loader (i.e. browserify, webpack, etc.) and thus this
is not necessary. make test-browser still passes after this patch.

@TooTallNate
remove explicit window.debug export
8b18dae 
Exporting to the "outer" scope of the module is more the responsibility
of the module loader (i.e. browserify, webpack, etc.) and thus this
is not necessary. `make test-browser` still passes after this patch.
@coveralls
Copy link

coveralls commented Dec 26, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 63.291% when pulling 8b18dae on remove/explicit-attach-to-window into 9a18d66 on master.

@thebigredgeek thebigredgeek merged commit 6646130 into master Dec 29, 2016
@TooTallNate TooTallNate deleted the remove/explicit-attach-to-window branch December 29, 2016 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TooTallNate @coveralls @thebigredgeek